Re: Seeking guidance for more idiomatic way of (re)writing this script.

in reply to Seeking guidance for more idiomatic way of (re)writing this script.

Two suggestions:

Wherever possible, avoid scattering hardcoded constants throughout the code. Instead, aim to make the script easily configurable. As a first step, move any data which could change into a hash:

my %config
(
    smtp_destination  => 'mail.server.com',
    nas_array_ip_list => 'C:/path/to/nas_array_ip_list.txt',
    smtp_msg_from     => 'name@email.com',
    smtp_msg_to       => 'name@email.com',
    mail_file         => 'C:/path/to/dmcheck.txt',
    username          => 'username',
    password          => 'password',
    reason            => '/nas/sbin/getreason',
    nasmailmsg_from   => 'name@email.com',
    nasmailmsg_to     => 'name@email.com',
    dm_check          => 'dmcheck.txt',
);
[download]

and access the hash data as needed:

MIME::Lite->send('smtp', $config{smtp_destination});

if (! open my $fh, '<',  $config{nas_array_ip_list})
...
[download]

As the next step, you may find it useful to populate the hash by reading in the data from a separate configuration file.

Avoid system calls where Perl has equivalent built-in functions. So, replace

system 'del dmcheck.txt';
[download]

with

unlink $config{dm_check} or warn "Could not unlink file '$config{dm_ch
+eck}': $!";
[download]

See unlink.

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

Comment on Re: Seeking guidance for more idiomatic way of (re)writing this script. Select or Download Code

In Section Seekers of Perl Wisdom