Re: Better solution to the code

[Punitha]

Hi, try this

open(FH1,"+>Result_file.txt") or die "Cannot create file $!\n";
open(FH,"<Input_file.dat") or die "Cannot read $!\n";
while(<FH>) {    
    my $data=$_;
    chomp($data);
    print FH1 "DATA:$data\n" if(grep/$data/,@tag);
}
close(FH);

Punitha.

[hipowls]

Precompiling the regexes should provide a speedup and using List::MoreUtils::any() may do if the chance of a match is good since the test will shortcut on success. Naturally you will benchmark;-)

use List::MoreUtils qw(any);

open my $OUT, '>', 'Result_file.txt' or die "Cannot create file: $!\n"
+;
open my $IN,  '<', 'Input_file.dat'  or die "Cannot read file: $!\n";

# precompile the regexes.
@tag_rx = map {qr/$_/} @tag;

while ( my $data = <$IN> ) {
    print $OUT $data if any { $data =~ /$_/ } @tag_rx;
}
close $IN;
close $OUT;