http://www.perlmonks.org?node_id=1005224


in reply to Recursive image processing (with ImageMagic)

I've published a script which uses Image::Magick, File::Find, and Spreadsheet::WriteExcel to convert a list of directories containing images into spreadsheets of thumbnails with dirified filenames, including a link to a larger thumbnail. It is of course a bit different from what you need, but some of the code may be useful.
  • Comment on Re: Recursive image processing (with ImageMagic)

Replies are listed 'Best First'.
Re^2: Recursive image processing (with ImageMagic)
by Anonymous Monk on Nov 23, 2012 at 07:48 UTC

    I small critic your code , instead of  if (@ARGV == 0)

    if( not @ARGV )

    if( ! @ARGV )

    unless( @ARGV )

    or

    @ARGV or exit print Usage();

[reply]
[d/l]
      There is nothing unclear about if (@ARGV == 0) which quite intuitively translates to "if the number of arguments is zero." Your alternatives are all fine, too, but there is no reason other than personal preference to prefer one over the other.


      When's the last time you used duct tape on a duct? --Larry Wall
[reply]
[d/l]

        There is nothing unclear (or evil, odd ) about your statement :) My small critic was not about clarity, but style -- perlishness

        "if no arguments" is more natural, its perlish

        If you feel like putting a number on it, you might say "if zero arguments" , but it doesn't follow the code 

        if( @ARGV == 0 )
if numarg is zero
if( 0 == @ARGV )
if zero is numargv

        [download]
[reply]
[d/l]

In Section Seekers of Perl Wisdom