Re^2: multi threading DBI

[Anonymous Monk]

I'm the OP. Thanks everyone and just to clarify a bit more: the script is slow because of the single thread internet connection. Yes, writing to sqlite is not fast (compared to most other real database server), but it is insignificant compared to grabbing stuff from the internet. Thanks BrowserUK for the list of stuff, I'm still going thru that, haven't found some source code that I can use yet. Meanwhile, I am actually opening a new dbh in each thread of my scrapper (stupid and not efficient.....)

[BrowserUk]

Thanks BrowserUK for the list of stuff, I'm still going thru that, haven't found some source code that I can use yet

If you post your single threaded code -- or a working, cut-down version of it -- I'll multi-thread it for you in the way I outlined; but I'm not going to try and re-create your code based upon your brief description.

[Anonymous Monk]

Thanks for offering, I have cut out the main part here:

my $dbh = DBI->connect("dbi:SQLite:dbname=event.db3", "", "", { RaiseE
+rror => 1, AutoCommit => 0 }, ) or die $DBI::errstr;
my @arr_uname = @{$dbh->selectcol_arrayref("select uname from event")}
+;
$dbh->disconnect();

foreach $uname(@arr_uname) {

   ###
   ###   all the LWP::Simple and the parsing happens here
   ###
   ###  [deleted]

   ### output result
   if ($result ne '') {
      $dbh->do("INSERT OR IGNORE INTO detail_info (id,uname,url,thumb,
+txt) VALUES (?,?,?,?,?)", undef, $$result{'id'},$uname,$$result{'url'
+},$$result{'thumb'},$$result{'txt'});
      $dbh->do("INSERT OR IGNORE INTO score_info (id,uname,tid1,tid2,t
+eam1,team2,) VALUES (?,?,?,?,?,?)", undef, $$result{'id'},$uname,$$re
+sult{'tid1'},$$result{'tid2'},$$result{'team1'},$$result{'team2'});
      $dbh->commit; 
   }
}

[BrowserUk]

Hm. That's not a "working, cut-down version" ...

So this isn't working either, but it ought to be close once you've filled in the blanks:

#! perl -slw
use strict;
use threads;
use Threads::Queue;
use LWP::Simple;
use DBI;

sub fetchNParse {
    my( $Qin, $Qout ) = shift;
    while( my $uname = $Qin->dequeue ) {
        my $content = get $uname;
        my @bits = $content =~ m[....];
        $Qout->enqueue( join $;, $uname, @bits );
    }
    $qOut->enqueue( undef );
}

our $THREADS //= 16;

my $Qunames = new Thread::Queue;
my $Qrets   = new Thread::Queue;

threads->create( \&fetchNParse, $Qunames, $Qrets )->detach for 1 .. $T
+HREADS;
my $dbh = DBI->connect( ... );
my $unames = $dbh->selectcol_arrayref("select uname from event");

$Qunames->enqueue( @$unames );

for( 1 .. $THREADS ) {
    while( my $ret = $Qrets->dequeue ) {
        my( $uname, @bits ) = split $;, $ret.
        $dbh->do( insert stuff );
    }    
}
$dbh->disconnect;