Re: Re: Some suggestions on coding style - a chance to critique

[emilford]

Dump the "&" in front of subroutine calls.

What is the reason for this? Does this make some sort of difference?

If you're using a hash, then use the hash:

    @$required = split /,/, $$formdata{'required'} unless ($$formdata{
+'required'} eq "");
    $$redirect = $$formdata{'redirect'} unless ($$formdata{'required'}
+ eq "");
.
.
.

I hate stuff like this. Assigning variables to hash values, IMHO, should only be done if you have some really complex data structures, and even then, I believe you should use some sort of interpolation, lest you continue to de-ref every time you access something

I'm not positive what you're refering to here. Is it just that I should use the hash in my code as opposed to assigning the hash values to a variable and then using the variable instead?

If you're printing to STDOUT in various places, set $|=1; Otherwise, push everything onto an array, and just dump the whole array when you're done

What exactly does the $|=1 do?

Thanks for the suggestions.