Re: Missing something with regards to references

[dpuu]

Sometimes with these "what am I missing" type of questions, the best approach is to explain how I'd do it, and then see if that answer somehow hits the one thing you need to understand.

Lets start with the function usage model: You suggest

  put_element( $DATA{3}, 'h', 'i', 'worked' );

For clarity, lets do the whole hash. You can create a reference to the top level (root) hash using the backslash operator:

  put_element( \%DATA, 3, 'h', 'i', 'worked' );

All those quotes get tiresome after a while, so lets get rid of them:

  put_element( \%DATA, qw(3 h i worked) );

Perl flattens arg-lists, so that is identical to the previous version.

So now the implementation (I'll omit the error-checks):

sub put_element {
  my ($hashref, @path) = @_;

  # The leaf node and its value are special
  my $value = pop @path;
  my $leaf = pop @path;

  # walk the tree, create non-existing nodes
  for my $node (@path) {
    $hashref = $hashref->{$node} ||= {};
  }

  # Finally, set the value at the leaf
  $hashref->{$leaf} = $value;
}

Hopefully the comments are sufficient to explain my thinking.

[scottb]

This is very elegant and makes much more sense to me, so thank you dpuu. But given some of the points that blokhead raised, are there any other gotchas with this approach I should be concerned about?

[dpuu]

I don't think so: my explicit default-assignment should avoid any autovivication issues.