Beefy Boxes and Bandwidth Generously Provided by pair Networks
more useful options
 
PerlMonks  

Re: Opening and closing files in loop

by Corion (Pope)
on Oct 22, 2012 at 08:33 UTC ( #1000290=note: print w/ replies, xml ) Need Help??


in reply to Opening and closing files in loop

You don't show the value(s) of $i and $max, so maybe there is a simple reason why your loop only gets run once.

Personally, I would change the coding style in two places to avoid nasty errors:

First, I would not use the C-style for construct but iterate over a range. I'd also use a lexical $i to avoid clobbering the loop counter through side-effects:

for my $i (1..$max) { ... };

Second, I would avoid using select for choosing the active output handle and print to the filehandles directly:

print DB qq("$dept$w$i, ..."\n); print newDB qq("$dept$w$i, ..."\n);

While rewriting your code to the new idiom, I saw that you seem to be running without warnings. As soon as you add use warnings; to the top of your script, or add -w to the Perl invocation, Perl will tell you what is going wrong.


Comment on Re: Opening and closing files in loop
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1000290]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (10)
As of 2015-07-28 11:08 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (254 votes), past polls