Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister
 
PerlMonks  

Re: Extracting code into a subroutine

by grizzley (Chaplain)
on Oct 31, 2012 at 09:59 UTC ( #1001633=note: print w/replies, xml ) Need Help??


in reply to Extracting code into a subroutine

First write differences down. Then design subroutine arguments. Then desing subroutine. What are the differences?
  • List of field indexes.
  • grep regexp (NETPACKET, NETERROR)
  • grep regexp (Network, Busy, Memory)
  • what to do with arguments?
  • others?
Then subroutine arguments:
sub yoursub { my ($rangearrayref, $firstre, $secondre, $subref) = @_; ... } yoursub([2..7], 'NETPACKET', 'Network', \&transformNetpacketSub);
or hash style:
sub yoursub { my %args = @_; my ($rangearrayref, $firstre, $secondre, $subref) = ($args{-range}, +$args{-firstre}, $args{-secondre}, $args{-transformsub}); ... } yoursub(-range => [2..7], -firstre=>'NETPACKET', -secondre=>'Network', + ->transformsub=>\&transformNetpacketSub);
And then the only problem is to write proper transformNetpacketSub. I would do it like this:
sub transformNetpacketSub { my $str = shift; # do anything with string return $str; }

Replies are listed 'Best First'.
Re^2: Extracting code into a subroutine
by cunningrat (Novice) on Oct 31, 2012 at 13:27 UTC
    Thanks to all who responded. It definitely gave me some ideas on how to proceed, which was all I needed.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1001633]
help
Chatterbox?
[1nickt]: The best way is to scope it tightly so it just goes away when you are finished with it.
[perldigious]: but... but... perldigious is the unvirtuous kind of lazy in this case. :-)
[perldigious]: Just kidding. Thanks 1nickt, I'll go ahead and do it the right way. An extra set of brackets and a little extra indentation isn't too much to ask.
[karlgoethebier]: perldigious: perhaps a block if you are paranoid ;-)
[choroba]: but undef %hash and %hash = () both work, too, but the first one keeps the memory allocated, while the latter makes it available for other parts of the program.
[choroba]: iirc

How do I use this? | Other CB clients
Other Users?
Others having an uproarious good time at the Monastery: (7)
As of 2017-07-21 19:49 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    I came, I saw, I ...
























    Results (335 votes). Check out past polls.