Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic
 
PerlMonks  

Re: else statement not being executed (tangential note))

by ww (Bishop)
on Nov 16, 2012 at 14:19 UTC ( #1004202=note: print w/ replies, xml ) Need Help??


in reply to else statement not being executed

For future reference, you may want to give some thought to the way you name variables. For example, the variable name $radius_times_2 (Ln 4) seems to suggest that it should contain a value double that of some radius... but you then define it as $radius_times_2 = 3.141592654; or pi.

Your first var, $radius_times = 2; (Ln 3) is only a little bit better. The value 2 has no per se relevance to radius; it's merely a multiplier, so why not call it $multiplier?

By the time you get to $radius_times_2 *= $radius_times (Ln 5), you're waaaaay out in the deep grass. OTOH, something like $pi_times_2 = $pi * $multiplier is far less likely to trip the unwary than a redefinition of $pi. Yes, it's clumsy (there are many reformulations that would improve my offering) and it's less concise, but clarity trumps brevity in most practical cases.

You can't confuse the computer with that kind of thing, but you sure can make it hard on yourself; some future maintainer, or even the muzzy-brained, early-morning monk who considered offering assistance.


Comment on Re: else statement not being executed (tangential note))
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1004202]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (10)
As of 2014-07-10 23:08 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    When choosing user names for websites, I prefer to use:








    Results (217 votes), past polls