Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling

Re: Global symbol requires explicit package name

by ColonelPanic (Friar)
on Nov 28, 2012 at 15:12 UTC ( #1006044=note: print w/replies, xml ) Need Help??

in reply to Global symbol requires explicit package name

To elaborate on what choroba said, the sub can see variables in the scope in which it is declared, not the scope in which it is called. In this case, printjob can only see variables that are either declared in the sub itself or in the outer scope of the file.

The "quick fix" would be to move those variable declarations outside the loops. However, as choroba said, the preferred solution is to pass everything that is needed into the sub.

In this case, it is not clear why %rtoa and @alljobs need to exist outside of runsingle. I would declare them there, then pass them in to printjob by reference:

sub runsingle { my %rtoa; my @alljobs; ... some code that actually populates the declared variables... printjob($fh,$h,\@foo,\%rtoa,\@alljobs); ... } sub printjob { my $fh=$_[0]; my $h=$_[1]; my $keys = $_[2]; my $rtoa = $_[3]; my $alljobs $_[4]; foreach my $key (@{$keys}) { ...

Also, the new style of filehandles is to use lexical variables directly. This eliminates the need for \*OUT:

open my $out_file, '>', 'filename.txt' or die "Ouch, $!";

When's the last time you used duct tape on a duct? --Larry Wall

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1006044]
and one hand claps...

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (10)
As of 2018-03-22 16:17 GMT
Find Nodes?
    Voting Booth?
    When I think of a mole I think of:

    Results (279 votes). Check out past polls.