Beefy Boxes and Bandwidth Generously Provided by pair Networks
Syntactic Confectionery Delight

Re: File open issue

by jwkrahn (Monsignor)
on Dec 20, 2012 at 04:13 UTC ( #1009683=note: print w/replies, xml ) Need Help??

in reply to File open issue

my $tempfile = "$tempdir/$ENV{'REMOTE_ADDR'}";

Quotes on a bareword hash key are redundant.

open (TMPFILE, "$tempfile")|| ($nofile = 1);

You shouldn't quote variables: What's wrong with always quoting "$vars"?    You are adding extra work for perl which has to interpolate the variable and then copy its contents to the string.

Because open returns true on success or false on failure you could simply do:

my $nofile = open TMPFILE, $tempfile;
my (@tmpfile) = <TMPFILE>;

The parentheses are superfluous because an array already provides list context.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1009683]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (7)
As of 2016-10-26 00:45 GMT
Find Nodes?
    Voting Booth?
    How many different varieties (color, size, etc) of socks do you have in your sock drawer?

    Results (330 votes). Check out past polls.