Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Re: Password (pseudo)casual

by Corion (Pope)
on Jan 23, 2013 at 15:19 UTC ( #1014928=note: print w/ replies, xml ) Need Help??


in reply to Password (pseudo)casual

Your generator cannot generate a password with the letters a, b or c due to the +3 when selecting the random letter. See rand, which already returns a number in the range from 0..$len.

The variable $len is named wrong - it has the last index of @lett, not the number of elements in the array. This means that your password generator would never output the last element from @lett if it weren't for the + 3 from the previous step. I would use:

$len = @lett;

... which assigns to $len the number of elements in @lett.

Other than that, using double quotes in a simple assignment is weird unless you have a special reason to do so - and if you are starting with Perl just now, those special reasons ("stringification") are still far away. So, no assignment should be of the form

$foo = "$bar";

and always of the form

$foo = $bar;


Comment on Re: Password (pseudo)casual
Select or Download Code
Replies are listed 'Best First'.
Re^2: Password (pseudo)casual
by cisco88 (Beadle) on Jan 23, 2013 at 15:24 UTC
    Thanks.
    The use of "$.." comes from the bash programming.
    Thinking about what you said made me realize that, indeed, the +3 is more damage than else.
    -- Luca Francesca <luca.francesca@ciscoland.eu> SysAdmin/Integrator @ Vodafone Italy & Ntt Data

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1014928]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others romping around the Monastery: (14)
As of 2015-07-31 09:46 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (276 votes), past polls