Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

Re^8: Install Math::GSL fail

by syphilis (Chancellor)
on Jan 25, 2013 at 07:38 UTC ( #1015280=note: print w/replies, xml ) Need Help??

in reply to Re^7: Install Math::GSL fail
in thread Install Math::GSL fail

I changed the two occurrences of return to XSRETURN, and the build succeeded

Whilst that will enable the build to succeed, it's unfortunately not the right solution.
XSRETURN() takes, as its argument, the number of elements to return from the stack. According to perldoc perlapi:
XSRETURN Return from XSUB, indicating number of items on the stack. This is u +sually handled by "xsubpp". void XSRETURN(int nitems)
I'm not sure what will happen if your version of that block of code gets executed and an attempt is made to return gsl_nan() items off the stack ... but I fully expect that it won't be pretty.
If that block of code gets executed, then it needs to XSRETURN(1), and the one item that it needs to return from the stack is whatever-it-is-that-is-returned-by gsl_nan(). (Presumably that's either a NaN, or a Math::GSL object that holds the value NaN.)

So long as that block of code never gets executed I think your fix should, however, be fine.


Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1015280]
[choroba]: Good morning!

How do I use this? | Other CB clients
Other Users?
Others romping around the Monastery: (7)
As of 2018-05-23 07:29 GMT
Find Nodes?
    Voting Booth?