in reply to Re: Squarepusher - A Tool To Convert Images To Audio For Oscilloscope X/Y Mode Displaysin thread Squarepusher - A Tool To Convert Images To Audio For Oscilloscope X/Y Mode Displays
Can’t speak for jdporter, but to my way of thinking the loops (C-style instead of foreach-style) are the least of the problems. To my old eyes the major issues are:
$mode never changes, but it’s re-tested each time through the main loop.
The code is monolithic and should be refactored into subroutines (one for each mode).
use warnings; and use strict; are missing, and all the variables are global.
Hope that helps,
In addition to the above:
Instead of long runs of single-line comments, use POD.
my $mode = shift;
my $frames = shift;
my $lossy = shift;
my $skip = shift;
my @bitmap = <>;
foreach $item (@bitmap)
@image = split //, join '', @bitmap;
It's not clear why
# If you don't want to use this optimization, just
# comment out the whole if statement.
DejaVu Sans Mono
Droid Sans Mono
Envy Code R
Source Code Pro
The default, whatever it is
Results (379 votes). Check out past polls.