Beefy Boxes and Bandwidth Generously Provided by pair Networks
Do you know where your variables are?
 
PerlMonks  

Re: Redefining Imported Subs: of scope and no

by LanX (Chancellor)
on Feb 09, 2013 at 02:22 UTC ( #1017918=note: print w/replies, xml ) Need Help??


in reply to Redefining Imported Subs: of scope and no

Long read!

(wont try it again! ;-)

I don't understand why you're using feature qw(say) if you wanna redefine 'say.

This makes say() a builtin which has to be overridden like described in perlsub#Overriding Built in Functions.

Otherwise this works:

$verbose=0; sub not_say { print 'not saying'; } sub say { print @_,"\n"; } { no warnings; *say = \&not_say if not $verbose; } say 'test';

or even simpler:

use strict; use warnings; no feature "say"; sub say { print "nothing"; } say 'test';

OTOH you will certainly have problems if someone manages to globally switch say on.

My suggestion is to replace say() with something like 'log()' or 'out()' and keep it simple, don't redefine the sub at all, just put the test condition into the function body.

Cheers Rolf

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1017918]
help
Chatterbox?
[stevieb]: cheers beech. twas totally my mistake, and I got bit. When things work for so long without issue, one becomes complacent (ie. replace we/one with I ;) I've been copy/pasting that around for a few years without a hiccup, so when...
[stevieb]: choroba pointed that out, I was just, you know, *sigh*. In effect, I was lucky and fortunate
[stevieb]: Kind of like my regex-fu went out the window, but only while looking at that specific file ;)

How do I use this? | Other CB clients
Other Users?
Others scrutinizing the Monastery: (5)
As of 2017-07-25 23:33 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    I came, I saw, I ...
























    Results (383 votes). Check out past polls.