Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine
 
PerlMonks  

Re^2: Printing Last Element of a line using perl memory?

by dave_the_m (Parson)
on Feb 15, 2013 at 12:53 UTC ( #1018887=note: print w/ replies, xml ) Need Help??


in reply to Re: Printing Last Element of a line using perl memory?
in thread Printing Last Element of a line using perl memory?

That code is bad in so many ways.

# open the file using _ to avoid multiple system calls invoked by perl open _,"filename";
This is complete nonsense. Using an underscore as the filename makes no difference to the execution, but makes the code harder to understand. Also, you should normally use lexical filehandles. Lastly, there's no error checking on the open.

my @lines=<_>;
This will crash with memory exhaustion if the file is too large
@lines[$#lines];
With warnings enabled, that will give:
Scalar value @lines[$#lines] better written as $lines[$#lines]
But could be even better written as
$lines[-1]

Dave.


Comment on Re^2: Printing Last Element of a line using perl memory?
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1018887]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others scrutinizing the Monastery: (9)
As of 2014-12-28 05:07 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    Is guessing a good strategy for surviving in the IT business?





    Results (178 votes), past polls