|No such thing as a small change|
Managing captureby jbert (Priest)
|on Feb 19, 2013 at 11:37 UTC||Need Help??|
jbert has asked for the
wisdom of the Perl Monks concerning the following question:
I've recently had a bunch of "fun" chasing down leaks in code (mine and others) caused by accidental capture of variables in callbacks.
e.g. something like:
Assuming that do_something hides the callback within $self, we've just created a cycle which if it doesn't get cleared (e.g. on an error path) will cause a leak (could leak mem, could leak other resources such as network connections. badness.)
Note that the logging could have been added casually, and doesn't look evil on a review diff.
One idea being bounced around here would be a pragma which declared "I don't want any vars to be captured implicitly" and a way of marking which vars are ok to capture.
The thinking is that this would make it clear and explicit what vars are being captured, so it is easy to see them and reason about them. Something like:
With the idea being that any vars which a closure would capture would be compile-time errors unless they are referenced in the 'capture' attribute.
So...is this madness? And has it already been implemented? Or do people resolve this pain in a different way?
(I know about weak refs, the issue is more about making it easy to know what to weaken.)
[Edit, added comment to code to emphasise that this doesn't prevent cycles, just makes them more visible.