Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Re^3: Managing capture

by Anonymous Monk
on Feb 19, 2013 at 12:32 UTC ( #1019539=note: print w/replies, xml ) Need Help??


in reply to Re^2: Managing capture
in thread Managing capture

To elaborate on competence, you said Note that the logging could have been added casually, and doesn't look evil on a review diff. except that it should -- when doing reviews you should be checking for cycles, esp with anonymous subs

But I don't really know what you mean by "review diff"

Also, you could write a perlcritic policy, it isn't too hard :)

Replies are listed 'Best First'.
Re^4: Managing capture
by jbert (Priest) on Feb 19, 2013 at 13:01 UTC

    > when doing reviews you should be checking for cycles, esp with anonymous subs

    I agree with this very much. But I think it is a hard problem. The intention of this pragma would be to make cycles caused via capture easier to spot in code review.

      I agree with this very much. But I think it is a hard problem. The intention of this pragma would be to make cycles caused via capture easier to spot in code review.

      Its not really that hard :) Devel::Cycle - Find memory cycles in objects

      It is easy to modify perlcritic ProhibitConditionalDeclarations to alert yo to closures for a code , and then you can further investigate to decide if they're really trouble, or ok

Re^4: Managing capture
by Anonymous Monk on Feb 19, 2013 at 12:52 UTC

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1019539]
help
Chatterbox?
[Corion]: Ouch. I just learned something about Chrome - the "version numbers" are not really feature numbers... Chrome 62 still gets new features even though Chrome 64 is out and Chrome 65 is the dev version
[erix]: why ouch? Something to be said for that ,surely?
LanX is a dev version
[marto]: That reminds me, I made some notes somewhere with regard W::M::C, I'll get round to a PR when I've time to flesh it out
[Corion]: erix: But that makes for fun bug hunting. "What version of Chrome are you running?" "v62". "I also run v62 and it works on my machine". :-(

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (9)
As of 2017-12-12 20:11 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    What programming language do you hate the most?




















    Results (335 votes). Check out past polls.

    Notices?