Re^2: Splitting a text file

[Dr Manhattan]

in reply to Re: Splitting a text file
in thread Splitting a text file

Hi all

I tried this and it seems to be working fine

my $length = $#array;
my $fileNR = 1;

for (my $x = 0; $x < $length; $x++)
{
    open ($fileNR, ">$fileNR.txt") or die "can't open";
    print $fileNR "$array[$x]\n";
    
    if ($x % 1000 == 999)
    {
        close ($fileNR);
        $fileNR++;
    }
}

Except that it doesn't print line 1 - 1000 to a file(as it should do), it just prints every 1000th line in a file, and then it goes on to the next file. Any idea why this happens?

[Ratazong]

Hi Dr Manhattan,

have a look at the difference between my algorithm and your solution: you open the file in each iteration of the loop. And by opening a file for writing, you erase the previous content.

The solution is to open the file before the loop. And (additionally) inside the if-block, when you want to switch to the next file.

HTH, Rata