Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change
 
PerlMonks  

Re^2: Module::Starter in Windows fails due to getpwuid() not working

by DarthBobToo (Initiate)
on May 24, 2013 at 15:18 UTC ( #1035165=note: print w/ replies, xml ) Need Help??


in reply to Re: Module::Starter in Windows fails due to getpwuid() not working
in thread Module::Starter in Windows fails due to getpwuid() not working

I'd love to fix the bug and submit the patch. Unfortunately, I'm at about a 'grasshopper' level of coding for the most part. :-)

Thanks for the pointer to the bug tho. It's good to know I'm not going insane.


Comment on Re^2: Module::Starter in Windows fails due to getpwuid() not working
Replies are listed 'Best First'.
Re^3: Module::Starter in Windows fails due to getpwuid() not working
by marto (Bishop) on May 24, 2013 at 15:27 UTC

    The test suite failed when I tried to install the module (Strawberry Perl 5.16, Windows 7 pro 64bit), I changed line 96 of Module::Starter::Simple.pm from:

    if ( not $self->{author} ) {

    To

    if ( ( not $self->{author} ) && ( $^O ne 'MSWin32' ) ) {

    So it'll fall through to:

    croak "Must specify an author\n" unless $self->{author};

    rather than fall in a heap because getpwuid isn't implemented in this platform. So yes, you'll have to provide a value fo author, but at least this way the test suite will pass, the module will install without a force and you'll be told what to do to make it work. As I say, I'll look into the problem in more detail and submit an appropriate patch when I get home.

    Update: added to explanation for clarity.

    Update: Patch submitted.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1035165]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chanting in the Monastery: (11)
As of 2015-07-28 23:06 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (260 votes), past polls