Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine

Re^4: Efficient bit counting with a twist.

by BrowserUk (Pope)
on Jun 01, 2013 at 09:49 UTC ( #1036400=note: print w/replies, xml ) Need Help??

in reply to Re^3: Efficient bit counting with a twist.
in thread Efficient bit counting with a twist.

What is going on here?

I tweaked your code by adding a couple of extra print statements:

my $mask = hex($ARGV[0]); print $mask; print unpack 'H*', $mask; my $setbits = unpack("%32b*", $mask); printf("0x%x has %d set", $mask, $setbits);

And when I run it I get this output:

C:\test>junk 0xff 255 ## 3 bytes 323535 ## 6 nybbles with bit patterns 0011 0010 0011 0101 0011 0101 0xff has 11 set

hex converts the string '0xff' to a number which you store in $mask;

unpack expects a string, so perl helpfully converts the number stored in $mask to a string in the default decimal representation '255'.

You are counting the bits in that 3 byte string.

To count the bits in the number, you need to tell perl that you want the binary representation of that number:

#! perl -slw use strict; my $mask = hex($ARGV[0]); print $mask; print unpack 'H*', pack 'C', $mask; my $setbits = unpack("%32b*", pack 'C', $mask ); printf("0x%x has %d set", $mask, $setbits); __END__ C:\test>junk 0xff 255 ff 0xff has 8 set

With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
"Science is about questioning the status quo. Questioning authority".
In the absence of evidence, opinion is indistinguishable from prejudice.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1036400]
[Discipulus]: good morning monks and nuns!
[Corion]: A good morning Discipulus! ;)
[Discipulus]: ah! all was well Corion?

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (9)
As of 2018-02-22 08:06 GMT
Find Nodes?
    Voting Booth?
    When it is dark outside I am happiest to see ...

    Results (288 votes). Check out past polls.