Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris

Re: RFC: Code testers/reviewers needed

by vsespb (Chaplain)
on Jun 07, 2013 at 08:49 UTC ( #1037632=note: print w/replies, xml ) Need Help??

in reply to RFC: Code testers/reviewers needed

1. $header->content_length is not available for chunked transfer (according to HTTP spec)
2. why are you mixing decoded_content and content_file ?
3. you are not checking if file downloaded correct (see mirror method in LWP::UserAgent)
4. is_success can give you false positives (but probably HEAD requests are OK in practice)
5. you can avoid HEAD requests at all - use LWP callbacks, you will be able to get length/last_mod_time before whole file is transferred

Replies are listed 'Best First'.
Re^2: RFC: Code testers/reviewers needed
by AI Cowboy (Sexton) on Jun 07, 2013 at 22:24 UTC
    All your points are good, I'll look into LWP callbacks so I can avoid HEAD requests - the mixing of decoded_content and content_file was due to me misunderstanding what decoded_content did. Can you elaborate what it does a little bit, for me?
      Documentation for decoded_content: Note that there is no content at all, as file downloaded using content_file option.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1037632]
[Discipulus]: meh second match lost 4-9 ;=(

How do I use this? | Other CB clients
Other Users?
Others about the Monastery: (5)
As of 2017-07-21 10:48 GMT
Find Nodes?
    Voting Booth?
    I came, I saw, I ...

    Results (321 votes). Check out past polls.