Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister

Re: RFC: beginner level script improvement

by eyepopslikeamosquito (Chancellor)
on Sep 20, 2013 at 09:13 UTC ( #1054982=note: print w/replies, xml ) Need Help??

in reply to RFC: beginner level script improvement

A few random suggestions after skimming your code:

  • Prefer lower case for variable names (your code looks like it's shouting).
  • Learn Perl here documents.
  • Spend more time choosing good names (descriptive, explanatory, consistent, regular, ... spelt-correctly ;-).
  • Your main program is way too long. Decompose it into modules. Write unit tests for each module. Avoid big-arse functions.
  • Run your script through Perl::Critic.
  • Prefer three-argument open.
  • Insert $! in your error strings when a Perl function fails.
  • Prefer low precedence or to ||; for example, prefer or die to || die.
  • Don't use a leading & when calling functions.
  • Avoid C-style for loops. For example, prefer for my $item (@arr) {...$item...} to for(my $I=0;$I<@ARR;$I++) {...$ARR[$I]...}.
  • Prefer my variables to our variables. Declare variables at point of first use (do not declare a huge bunch of variables at the top of a subroutine). Minimize variable scope. Avoid global variables.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1054982]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others rifling through the Monastery: (4)
As of 2018-02-23 21:21 GMT
Find Nodes?
    Voting Booth?
    When it is dark outside I am happiest to see ...

    Results (310 votes). Check out past polls.