Beefy Boxes and Bandwidth Generously Provided by pair Networks
There's more than one way to do things
 
PerlMonks  

Re: Can you make it nicer?

by boftx (Deacon)
on Nov 18, 2013 at 22:40 UTC ( #1063216=note: print w/ replies, xml ) Need Help??


in reply to Can you make it nicer?

I'm not convinced I like any of the above when it comes to readability. Here is what I came up with that might make it easier for a junior-level programmer to at least have half a clue as to what is going on (it being understood that my choice of variable names could be better):

sub id2path_boftx { my $id = shift or return q(); # my $chunk_length = length $id > 6 ? 3 : 2; my $chunk_length = $id < 1e6 ? 2 : 3; my $path_pat = '%0' . $chunk_length . 'd'; $path_pat = join('/', $path_pat, $path_pat, $path_pat); my $chunk_power = 10 ** $chunk_length; my $path = sprintf $path_pat, $id / ($chunk_power ** 2), ($id / $chunk_power) % $chunk_power, $id % $chunk_power; return $path; }

FWIW, it passes all 23 tests.

Update: Changed how $chunk_lentgh is determined. I like the numeric test better after looking at it for a while.

It helps to remember that the primary goal is to drain the swamp even when you are hip-deep in alligators.


Comment on Re: Can you make it nicer?
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1063216]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others studying the Monastery: (13)
As of 2015-07-06 22:12 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (83 votes), past polls