Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"
 
PerlMonks  

Re: Can you make it nicer?

by zork42 (Monk)
on Nov 19, 2013 at 17:19 UTC ( #1063362=note: print w/ replies, xml ) Need Help??


in reply to Can you make it nicer?

I'm a little nervous to comment... I hope this won't offend anyone...
IMVHO I think the clearest code is rminner's code.
IMVVHO The 2nd clearest is ... oh look over there, a spider ... *whispers* the original code.
IMVVVHO Both make it very clear what the 2 different cases are, and what to do for each of them.

I like to line things up to help highlight the similarities and differences, so I might write it like this:

sub id2path_new { my ($id) = @_; return '' unless $id; my $path = ''; if ($id >= 1_000_000) { $path = sprintf("%09d", $id); $path =~ s +#\A(.*)(...)(...)\z#$1/$2/$3#; } else { $path = sprintf("%06d", $id); $path =~ s +#\A(..) (..) (..)\z#$1/$2/$3#x; } return $path; }


Comment on Re: Can you make it nicer?
Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1063362]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (9)
As of 2015-07-29 21:03 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (269 votes), past polls