Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"
 
PerlMonks  

Re: Array comparison doesn't work

by davido (Archbishop)
on Nov 23, 2013 at 18:55 UTC ( #1064068=note: print w/replies, xml ) Need Help??


in reply to Array comparison doesn't work

You double-posted this (Reaped: Array comparison doesn't work). Remember it can take a few minutes for a post to be approved.

As for your problem, arrays flatten when passed as parameters. You should be passing array references instead, to maintain the original containers.

Please see perlsub for details. No point re-stating everything it says unless there's some aspect of that POD that needs clarification. But in brief:

sub flattened { my( @a, @b ) = @_; return @a; # Returns everything. } sub preserved { my( $a_aref, $b_aref ) = @_; return @$a_aref; # Returns only the stuff contained in @$a_aref. } my @this = qw( 1 2 3 ); my @that = qw( 4 5 6 ); print "$_\n" for flattened( @this, @that ); # prints 1 2 3 4 5 6. print "$_\n" for preserved( \@this, \@that ); # prints 1 2 3.

Dave

Replies are listed 'Best First'.
Re^2: Array comparison doesn't work
by vihar (Acolyte) on Nov 23, 2013 at 20:24 UTC
    I am sorry. Didn't realize it double posted but thanks for making this array confusion clear for me!

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1064068]
help
Chatterbox?
[marinersk]: sub newtest{my $expected_result = &target('foo'); my $actual_result = &target('foo'); if ($actual_result eq $expected_result) { &tdd_success(); } else { &tdd_fail(); } } # Test works after three years!
[choroba]: or nobody bothered...
[choroba]: The problem was bigger, as the test tried to call a method that didn't exist anymore
[marinersk]: :: ducking ::
[choroba]: because, someone renamed the method, but didn't notice it was used in the test, as the test was skipped
[marinersk]: Well, if the method doesn't exist, it would be hard to pass the test.
[choroba]: later, someone removed the new method, as all its usage places were safe, but didn't notice the test still used the old name
[choroba]: fortunately, it wasn't that hard to replace the method and fix a few remaining failures due to the changes we did to the codebase over the years
[marinersk]: choroba Sounds like a process improvement opportunity; tests may not all need to be run, but they should all be compiled with perl -c before check-in/promotion happens.
[choroba]: so, now I have the test, so I can start making changes in the code. Back to the original ticket, yay!

How do I use this? | Other CB clients
Other Users?
Others having an uproarious good time at the Monastery: (15)
As of 2017-05-25 15:12 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?