Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Re^5: Suggestions to make this code more Perlish

by kcott (Abbot)
on Mar 31, 2014 at 06:55 UTC ( #1080358=note: print w/ replies, xml ) Need Help??


in reply to Re^4: Suggestions to make this code more Perlish
in thread Suggestions to make this code more Perlish

Thanks for the documentation link. That certainly has a lot more text than I found where I was previously looking: and no "TODO"s in sight. I have a bit of reading ahead of me.

Yes, I was aware of why I was getting two \037 characters at the end (in the first solution). What I haven't figured out yet is why I was getting zero \037 characters at the end (when I changed ',?' to '(?:,|\000)' — in the second solution).

Thanks also for the additional feedback: much appreciated.

-- Ken


Comment on Re^5: Suggestions to make this code more Perlish
Select or Download Code
Re^6: Suggestions to make this code more Perlish
by TheDamian (Priest) on Mar 31, 2014 at 07:40 UTC
    What I haven't figured out yet is why I was getting zero \037 characters at the end (when I changed ',?' to '(?:,|\000)' in the second solution).

    My apologies for misinterpreting your implied question.

    The reason your second solution is producing zero trailing "\037" characters is because (?:,|\000) can never match nothing. It either matches a trailing comma, or a trailing null character. So on the very last field (which has neither a trailing comma nor a trailing null-byte), your field pattern wasn't matching at all, so you were not rewriting the last field at all, hence no extra "\037" was added after it.

    And, because that final field failed to match, the global matching sequence was terminated at that point, so the regex didn't do that one extra "match an empty field at the end" iteration, which was previously adding the second "\037".

    Technically, the use of '(?:,|\000)' introduced a bug, as it would then treat any embedded null as a field separator. Granted, it is quite unlikely to find an embedded null in a CSV file, but not impossible.

    If you wanted to keep using this approach, you could avoid that nasty edge-case by replacing the (?:,|\000) subpattern with a simple comma:

        my $re = qr{ (?: "(?<a>[^"]*)" | (?<a>[^,]*) ) , }x;

    Damian

      ++ Thankyou very much.

      Once explained, it now seems obvious. One of those "need a fresh set of eyes" situations.

      My focus had been on why '$+{a}' was being replaced instead of '$+{a}\037'. Of course, no replacement is taking place at all. Doh!

      -- Ken

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://1080358]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others meditating upon the Monastery: (6)
As of 2014-12-21 06:22 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    Is guessing a good strategy for surviving in the IT business?





    Results (104 votes), past polls