Beefy Boxes and Bandwidth Generously Provided by pair Networks
Don't ask to ask, just ask

Re (tilly) 1: OK... I am confused and lost :( Editing FlatFile

by tilly (Archbishop)
on Aug 28, 2001 at 21:14 UTC ( #108508=note: print w/replies, xml ) Need Help??

in reply to OK... I am confused and lost :( Editing FlatFile

If you find yourself writing long strings of named variables, particularly if you have to synchronize them between different pieces of code you should use hashes and hash slices.

For instance suppose that somewhere you have:

@fields = qw( viewpositionid institution department confirstname conlastname conemail conphone titleposition posnumbert typeposition programtype dvmonth dvday dvyear edmonth edday edyear numposition numvacunit totsalary budgetsalary statefundsources fedfundsources statebudgetcat priclass subip thetime approved );
Then your loop could be replaced with:
foreach my $rec (@ODB) { chomp($rec); my %db_rec; @db_rec{@fields} = split /\t/, $rec; if ($db_rec{viewpositionid} == $cur_rec{viewpositionid}) { # Replace the existing with the updated. %db_rec = %cur_rec; $cur_rec{sub_ip} = $ENV{REMOTE_ADDR}; $cur_rec{approved} = "No"; } print DATABASE join "\t", @db_rc{@fields}; print DATABASE "\n"; }
which is much clearer, and less error prone. (I would choose easier names to read and also try to lose the flatfile database, but one step at a time...)

The key points here are that people tend to mess up positional logic (computers don't) and you want to try to reduce the number of places that any given item of information (eg what fields appear in what order). Plus losing a ton of globals is generally a Good Thing...

Updated Steve_p - fixed the opening code tag on the second block of code

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://108508]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others taking refuge in the Monastery: (6)
As of 2017-10-20 14:43 GMT
Find Nodes?
    Voting Booth?
    My fridge is mostly full of:

    Results (263 votes). Check out past polls.