Re: Perl script does not work on other directories?

[james28909]

heres another way, tho it still does not use chdir, but it does work from the scripts location and all you have to feed it is the absolute path or from script path as arg.

use strict;
use warnings;
use diagnostics;
use File::Slurp;
#use Cwd;

my @files;


get_args();

sub get_args {

    my $dir;
    my $string;

    print "enter path\n";
    chomp( $dir = <STDIN> );
    
    print "enter match string\n";
    chomp( $string = <STDIN> );
    print "\n";

    @files = read_dir($dir);

    print $_ for @files ;

    traverse( $dir, $string );
}

sub traverse {
    
    foreach my $element (@files) {
       
        open $file, "<", $dir.'/'.$element;

        while (<$file>) {
            if ( $_ =~ m/$string/i ) {
                print "found $string in $element\n";
            }
        }
        close $file;
    }
    get_args();
}

to me its more manageable if it is broken up in subroutines. that way you can have one function to get the input, then the other to actually collect results.

EDIT: here is the newest code, which i have not really looked any further into this tbh, but you should be able to add chdir and list dir contents pretty easily. Could maybe even add switches for searching cwd for the string you needed.

use strict;
use warnings;
use diagnostics;
use File::Slurp;
#use Cwd;

my @files;

get_args();

sub get_args { 

        print "enter path: ";
        chomp( my $dir = <STDIN> );
        
        print "enter match string: ";
        chomp( my $string = <STDIN> );

        @files = read_dir($dir);

        print "\n", $_ for @files, "\n" ;
    
    traverse( $dir, $string );
}

sub traverse {
    
    my ( $dir, $string ) = @_;
    
    for my $element (@files) {
        open (my $file, '<', "$dir/$element") || next;

        while (<$file>) {
            if ( $_ =~ m/$string/i ) {
                print "found $string in $element\n";
            }
        }
        close $file;
    }
    print "\n";
    get_args();
}

[Anonymous Monk]

Why write  traverse( $dir, $string ); if you're using fake globals?

[james28909]

the script complained when i tried to declare them only when i needed them. but yes you are correct and i completely missed that. i changed the script on my machine and declared the variables inside their respective subroutine and its working fine. thanks for pointing that out :)

[Anonymous Monk]

... i changed the script on my machine and declared the variables inside their respective subroutine and its working fine....

Hmm, I don't think I see that reflected in the code you posted, will you do an update?

[james28909]

Here is my last attempt. This will print directories then files and you can traverse directories easily. typing ".." at "enter path" will get you to parent dir

use strict;
use warnings;
use diagnostics;
use File::Slurp;
use Cwd;

for(;;){   

    my @files;

        my $dir;

        print "enter path: ";
        chomp( $dir = <STDIN> );

        chdir($dir);
        $dir = getcwd($dir);
        print $dir;

        # print "enter match string: ";
        # chomp( my $string = <STDIN> );

        @files = read_dir($dir);

        foreach my $element (@files) {
            next if -f $element;
            print "$element\n";
        }

        foreach my $element (@files) {
            next if -d $element;
            print "$element\n";
        }

        print "\ncurrent dir is: $dir\n";
        print "\n";

    system("pause");
    system("cls");

}

[james28909]

i was trying to figure out how to sort the -d and -f without having to use two loops. but i am unsure how to use sort to do such a thing.

[SuicideJunkie]

You want to compare one thing, and then if it's the same, compare something else, and continue until you're sure they're both identical.

@results = sort 
{
   MostImportantFeature($a) <=> MostImportantFeature($b)
   or
   NextFeature($a) <=> NextFeature($b)
   or
   LeastImportantFeature($a) <=> LeastImportantFeature($b)
}
@source;