Re: Improvement suggestions?

[Masem]

You've got -w , but not use strict. While I think your code is strict already, it's always a good idea to have this.

It's much easier to glob a file list, than to use a system call; the former is more portable than other methods. That is, you can reduce your pre-function code to :

#!/usr/bin/perl -w
use strict;
use HTML::Clean;
clean_file( $_ ) foreach glob "*.html";

You should always catch errros from file system calls like open, that is, you should do open (OUTPUT, ">$filename") or die "Can't open $filename: $!"; to get meaningful errors.

IMO, it would also be better to write to a temporary file then move the file over using rename than to write over an existing file. This would minimize the chance of errors losing any original HTML files to start with.

Everything else seems good from a programmer's standpoint.

-----------------------------------------------------
Dr. Michael K. Neylon - [e-mail] || "You've left the lens cap of your mind on again, Pinky" - The Brain
It's not what you know, but knowing how to find it if you don't know that's important

[sheridan3003]

Thanks. That is what I was looking for. This looks much more like PERL than some of the other languages that I program in.