package/scope question

[pbradley]

hello, I'm very new to perl and have come across an aggrivating issue which I have not been able to find a solution too. I'm writing test scripts that will pump messages into the application I'm testing. My design of the scripts was to have one larger framework.pl file that would include all the setup that every test will need. then I would have a test .pl file for every type of test and that perl file would just include (or require) the framework.pl file. every thing works fine until in one of the tests I need to be able to change a variable in the framework.pl file. My problem in the most basic form is this: the framework.pl file:

package framework;
use strict;
my $date = "2001-11-12";
sub testcase1
{
     print $date;
}

the test.pl file:

require "framework.pl";

$framework::date = "2001-12-05";
&framework::testcase1;
$framework::date = "2001-11-15";
&framework::testcase1;

the output after running this test is 2001-11-122001-11-12. the date is not being changed like I thought it would be. Does anybody know of an easy way for me to access and change frameworks $date variable from within the test.pl? Any help would be greatly appreciated. thanks.

[davorg]

Inside the framework package you declare $date as a lexical variable. This means that the variable is only visible inside the framework.pl file.

Inside your main package, you try to access a package variable called $framework::date. This is a completely separate variable to the lexical that you declared previously. This is why updating it has no effect on the output from testcase1 - you're updating the wrong variable.

Easiest solution is to replace the lexical variable declaration with a package variable declaration in framework.pl like this:

use vars '$date';

(or our $date if you're using Perl 5.6.x)

--
<http://www.dave.org.uk>

"The first rule of Perl club is you don't talk about Perl club."

[jeffa]

How about using our instead of my:

use strict;
require 'framework.pl';

$framework::date = "2001-12-05";
&framework::testcase1;
$framework::date = "2001-11-15";
&framework::testcase1;

------------------------------------------

package framework;
use strict;

our $date = "2001-11-12";
sub testcase1 { print "$date\n"; }

1; # don't forget to return true value!!

I don't use our very much, but it seems applicable here. Personally, i would opt for the more standard OO approach:

use strict;
require 'framework.pl';

my $fw = framework->new();

$fw->set_date("2001-12-05");
$fw->testcase1();

$fw->set_date("2001-11-15");
$fw->testcase1();

-----------------------------------------

package framework;

sub new {
   my $class = shift;
   my $self = { date => '2001-11-12' };
   return bless $self, $class;
}

sub set_date {
   my ($self,$date) = @_;
   shift->{'date'} = $date;
}

sub testcase1 { 
   print shift->{'date'}, "\n";
}

1;

Perhaps Test::Simple or Test::Unit would be helpful to you as well.

(this node updated with minor tweaks and such...)

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
F--F--F--F--F--F--F--F--
(the triplet paradiddle)

[pbradley]

when I try the our approach I get warnings and errors: use of reserved word our depricated at line.... Variable $date is not imported at framework line.. Global symbol $date requires explicit package name at ... when I try the OO approach, I get the following error: framework.pl did not return a true value at test.pl line 2. one thing I should mention that may make a difference is that I am not putting any of my files in the perl lib path. (and I hope very much to avoid doing this as the setup for the test is already complex enough without having to do this)

[jeffa]

Sounds like you are using an older version of Perl - try perl -v to see which version you are using.

Like i said, i personally stick with the OO style - you need to simply stick 1; as the last line in framework.pl

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
F--F--F--F--F--F--F--F--
(the triplet paradiddle)

[pbradley]

my bad I forgot to put the return value in.. thanks.