Re: Re: Local::SiteRobot - a simple web crawling module

[rob_au]

in reply to Re: Local::SiteRobot - a simple web crawling module
in thread Local::SiteRobot - a simple web crawling module

The problems which I encountered with WWW::SimpleRobot related to the traverse function not returning traversal results via the $object->pages and $object->urls methods - The problem appeared to relate to the shift method by which the author was iterating through the constructed queue undefining the @pages results array before it was returned at the end of the function.

Better than just reporting this to the author, I have submitted a fix patch which corrects this behaviour by pushing results into a separate array to the queue.

115a116
>     my @results;
150a152
>             push (@results, $page);
165,166c167,168
<     $self->{pages} = \@pages;
<     $self->{urls} = [ map { $_->{url} } @pages ];
---
>     $self->{pages} = \@results;
>     $self->{urls} = [ map { $_->{url} } @results ];

Note that I never meant for my little piece of code to be viewed as a code fork from WWW::SimpleRobot but rather just an additional available option.

 

Ooohhh, Rob no beer function well without!