Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister
 
PerlMonks  

Re: (Ovid) (2): Would you use 'goto' here?

by dmmiller2k (Chaplain)
on Dec 06, 2001 at 20:11 UTC ( #129947=note: print w/replies, xml ) Need Help??


in reply to (Ovid) Re: Would you use 'goto' here?
in thread Would you use 'goto' here?

Clearly, the "goto-&NAME" form was intended for use by the low-level "magic" (as perrin so aptly put it in Re: Would you use 'goto' here?) of AUTOLOAD, which, just as clearly, is a dispatch function. Since you're also using it for dispatching, it seems on the one hand appropriate.

On the other hand, quite a few responses to this node (in particular, Masem's, in which he says, "I think the fact that you had to explain the special form in your errata to the original message is a good enough reason") seem to indicate that this form of goto may not be widely used enough to consider it an "idiom" (in contrast with some other widely used constructs nevertheless frequently misunderstood by experienced C/C++/Java programmers new to Perl).

If your goal, as you say, is to "optimize for correctness and clarity", then this might not be the ideal solution. How important is the call stack in a production app anyway? Isn't that more to do with debugging than with normal usage?

IMHO, you're much better off switching to:

return edit_office_product(@_) if $query->param('officeID');

as first suggested by runrig in Re: Would you use 'goto' here? in this thread.

dmm


You can give a man a fish and feed him for a day ...
Or, you can teach him to fish and feed him for a lifetime

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://129947]
help
Chatterbox?
[Corion]: Oh yay. I wonder why a very simple change in a program doesn't elicit a diff, and now I see that my diff program seems to have a bug ;)
[1nickt]: marto thanks for asking, so far so good. A pretty modern stack and decent procedures, although rather too much home-built stuff (e.g. a logging role that should tries to duplicate Log::Any).
[Corion]: No. It's just that I'm comparing the same output file twice, instead of comparing the output files of the two runs %-)
[Corion]: Lo and behold, running a program with the correct input files yields the correct (and expected) output. Yay me.
[1nickt]: Got a MacBook and am expected to develop directly on it, ironic given the recent thread about that.
[marto]: Corion, some not too serious issues with the kids, hopefully, other than that just dealing with commuting by car again in the winter, not much fun so far, and there's no real 'bad' weather yet :)
[marto]: 1nickt, glad to hear it, I'm sure you'll bring improvements to their stack in due course ;)
[1nickt]: Just trying to adjust to a new culture. Better doc than I am used to , but quite a bit more Agiley meta-bullshit; at least half a dozen meetings a week, strict "sprint" schedule etc. I'll adjust. And I hope to just switch off after the "scrum" each day at
[1nickt]: ... the end of the afternoon. marto How are you, snowed in? Mum and Dad expecting snow today in Surrey. (Have 5" on the ground here in NJ. And my son's high school in SOCal closed until after Xmas due to fires.)
[Corion]: 1nickt: In a sense the meta-bullshit might even be beneficial to you as you get to hear the cow-orkers talk (or not talk) about the issues you perceive. I think Agile is mostly about the meta ;)

How do I use this? | Other CB clients
Other Users?
Others about the Monastery: (5)
As of 2017-12-11 11:45 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    What programming language do you hate the most?




















    Results (289 votes). Check out past polls.

    Notices?