Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"
 
PerlMonks  

Re: Re: How do you critique another person's code?

by VSarkiss (Monsignor)
on Dec 19, 2001 at 22:49 UTC ( #133211=note: print w/ replies, xml ) Need Help??


in reply to Re: How do you critique another person's code?
in thread How do you critique another person's code?

This is excellent advice. I can't emphasize this point strongly enough:

ensure that the cards are all face up on the table
This includes your own. Make sure you're clear about your motivations and what you want to achieve. If you're only after improving the code, then your style will not matter. If you have a personal beef with the programmer, it will.


Comment on Re: Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133211]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (6)
As of 2014-09-02 00:46 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My favorite cookbook is:










    Results (18 votes), past polls