Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Re: Re: How do you critique another person's code?

by VSarkiss (Monsignor)
on Dec 19, 2001 at 22:49 UTC ( #133211=note: print w/replies, xml ) Need Help??


in reply to Re: How do you critique another person's code?
in thread How do you critique another person's code?

This is excellent advice. I can't emphasize this point strongly enough:

ensure that the cards are all face up on the table
This includes your own. Make sure you're clear about your motivations and what you want to achieve. If you're only after improving the code, then your style will not matter. If you have a personal beef with the programmer, it will.

  • Comment on Re: Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133211]
help
Chatterbox?
[erix]: potshots at potus. It was kinda encouring when they started shooting a republican senators ;)
[LanX]: I'm not calling for shooting Trump with a golf ball ;-)

How do I use this? | Other CB clients
Other Users?
Others wandering the Monastery: (10)
As of 2017-08-18 12:58 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Who is your favorite scientist and why?



























    Results (301 votes). Check out past polls.

    Notices?