Beefy Boxes and Bandwidth Generously Provided by pair Networks
more useful options
 
PerlMonks  

Re: How do you critique another person's code?

by dws (Chancellor)
on Dec 19, 2001 at 23:35 UTC ( #133231=note: print w/replies, xml ) Need Help??


in reply to How do you critique another person's code?

How can I politely provide factual feedback without "attacking" the style of programming? ... the programmer is pretty young.

Given what you've shown, this seems to me to be as much a behavioral issue as it is a technical one. It looks like a situation where the older developer needs to sit the younger developer down and explain that behavior has consequences, and that coding (and commenting) practices are a behavior. This kind of talk is best done one-on-one, without managers present.

Unfortunately, that opportunity has been missed, and it's now "meeting with managers" time. Given that, I would focus on the technical aspects of the problems with the code and their likely downstream consquences. Avoid making it personal, even if baited.

  • Comment on Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133231]
help
Chatterbox?
[choroba]: Isn't Using PerlPod Creatively rather a meditation?
[choroba]: I don't see a question
[1nickt]: ugh, I stuck my head in the bass bin for 30 seconds on a dare at Ted Nugent at Hammersmith Odeon. Yes, I am 40% deaf now.
[johngg]: My daughter is incredibly jealous of my wife who got to see The Clash at Brixton many years ago. They went to see The Vaccines there recently.
[1nickt]: But the bands are even louder! I saw Spearhead (Michael Franti) at an outdoor show and had to walk a mile away to not feel pain in my chest! Babies were crying ... I asked the sound engineer why it was necessary to have the bass so loud and he laughed...
[Discipulus]: but the best i attended live was Mano Negra Patchanka at Forte Prenestino .. in 1990
[Corion]: Hmmm - Mano Negra or at least Manu Chao seem to put on a good live show. At least the one live CD I have from Manu Chao sounds good ;)
Discipulus feels the same jealousity of the johngg's daughter
[1nickt]: choroba I agree
[choroba]: Playing in a punk rock band for 20 years... my hearing is quite bad

How do I use this? | Other CB clients
Other Users?
Others surveying the Monastery: (13)
As of 2017-03-24 12:17 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Should Pluto Get Its Planethood Back?



    Results (301 votes). Check out past polls.