Beefy Boxes and Bandwidth Generously Provided by pair Networks
Don't ask to ask, just ask

Re: How do you critique another person's code?

by dws (Chancellor)
on Dec 19, 2001 at 23:35 UTC ( #133231=note: print w/replies, xml ) Need Help??

in reply to How do you critique another person's code?

How can I politely provide factual feedback without "attacking" the style of programming? ... the programmer is pretty young.

Given what you've shown, this seems to me to be as much a behavioral issue as it is a technical one. It looks like a situation where the older developer needs to sit the younger developer down and explain that behavior has consequences, and that coding (and commenting) practices are a behavior. This kind of talk is best done one-on-one, without managers present.

Unfortunately, that opportunity has been missed, and it's now "meeting with managers" time. Given that, I would focus on the technical aspects of the problems with the code and their likely downstream consquences. Avoid making it personal, even if baited.

  • Comment on Re: How do you critique another person's code?

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133231]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others rifling through the Monastery: (5)
As of 2016-10-27 00:46 GMT
Find Nodes?
    Voting Booth?
    How many different varieties (color, size, etc) of socks do you have in your sock drawer?

    Results (350 votes). Check out past polls.