|go ahead... be a heretic|
Re: How do you critique another person's code?by ellem (Hermit)
|on Dec 20, 2001 at 00:27 UTC||Need Help??|
I can empathize with the writer of this absolutely bizarre code; but only because I was recently singled out in a meeting as an example of "The Way Not To Do It".
My bosses specific complaint was that my Perl code was too "boring", "obvious", "clear", "over commented", and "cautious". (I'm a Sys Admin not a programmer by profession.) Anylou...
My code was displayed on a wall and my boss basically showed everyone why he didn't like this and that. One of the programmers did stick up for me and say that he could go into that code at anytime and work on it, and that was good, but mostly folks just ripped on me.
It did nothing to my style... I still code the same basic way (although I do REM out use diagnostics ; now.)
Just be very specific. And definitely make sure to make a point about that commenting style: That junk is fine for a homepage hosted on a personal computer but has no business in the real world.
There's more than one way to do it, just don't use my way.