Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine
 
PerlMonks  

Re: Re: How do you critique another person's code?

by vladb (Vicar)
on Dec 20, 2001 at 02:17 UTC ( #133286=note: print w/ replies, xml ) Need Help??


in reply to Re: How do you critique another person's code?
in thread How do you critique another person's code?

Ellem, I can hardly believe your boss could do such a thing!? I remember myself at a few code reviews for my perl programs, and even that was a little tense. I later came to terms with the idea of code reviews and saw their impact as to the 'betterment' of my code.

However, your boss just scolded you right there!

I think that if your code was indeed "obvious", "clear", "over commented", and (above all) "cautious", then I'd step in and support it. Clearly, these are the qualities that do not hurt one's code but rather make it maintainable and less bug-prone.

PS: I'm absolutely with you on your commnet about "that junk".

"There is no system but GNU, and Linux is one of its kernels." -- Confession of Faith


Comment on Re: Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133286]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others romping around the Monastery: (16)
As of 2014-07-24 20:39 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My favorite superfluous repetitious redundant duplicative phrase is:









    Results (167 votes), past polls