Beefy Boxes and Bandwidth Generously Provided by pair Networks
Clear questions and runnable code
get the best and fastest answer
 
PerlMonks  

Re: How do you critique another person's code?

by chromatic (Archbishop)
on Dec 20, 2001 at 03:01 UTC ( #133312=note: print w/ replies, xml ) Need Help??


in reply to How do you critique another person's code?

If I were you, I would rewrite the sections in question. I might say something like, "The existing code relies on side effects and undocumented assumptions. It is fragile and could be made more clear. Here is my suggestion for an improvement."

If you lay them out side by side, it'll be obvious... assuming the other people know sufficient Perl.

I'd leave the issue of comments alone. Again, assuming the other people have a decent grasp (graps?!) of the English language, they'll likely come to the same conclusion you did without having to be told how to feel about them.

If you're in a politically charged position, you may be better off leading people to your opinion than presenting it as an opposing position -- especially if the existing code is already in place and doing its job. (For what it's worth, the only problem I have with the substr code is the need to assign to $_. That's useless.)


Comment on Re: How do you critique another person's code?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133312]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chanting in the Monastery: (9)
As of 2014-10-24 13:03 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    For retirement, I am banking on:










    Results (131 votes), past polls