Beefy Boxes and Bandwidth Generously Provided by pair Networks RobOMonk
Pathologically Eclectic Rubbish Lister
 
PerlMonks  

Re: (Style is more than formatting) - How do you critique another person's code?

by buzzcutbuddha (Chaplain)
on Dec 20, 2001 at 23:13 UTC ( #133570=note: print w/ replies, xml ) Need Help??


in reply to Re: How do you critique another person's code?
in thread How do you critique another person's code?

Style is always more than formatting.

Look at 'Code Complete', a weighty tome all about formatting that covers a lot more ground than just where to put braces and the merits of tabs over spaces.

Beyond that look at something like the 'Chicago Style Manual for Writers'. It also deals with style and is more than just formatting. It addresses passive sentences vs. active sentences, word order, proper grammar, etc.

The array slices the unnamed programmer was using are bad Perl grammar, as egregious as "That's something I ain't puttin' up with" in the English language. Let's all say it together: 'Style is NOT formatting.'

Ok, I'll relinquish the soap box now.


Comment on Re: (Style is more than formatting) - How do you critique another person's code?
Re: Re: (Style is more than formatting) - How do you critique another person's code?
by runrig (Abbot) on Dec 20, 2001 at 23:28 UTC
    runrig stammers: "Style...is...NOT...formatting"

    There, I said it. But it does include formatting to some degree, and the 'etc.' that I listed implicitly includes all the other stuff :)

      Sure, how about we change it to say: Style is NOT JUST formatting. :)

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133570]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others imbibing at the Monastery: (13)
As of 2014-04-21 14:51 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    April first is:







    Results (495 votes), past polls