Beefy Boxes and Bandwidth Generously Provided by pair Networks
The stupid question is the question not asked
 
PerlMonks  

Re: How do you critique another person's code?

by Dominus (Parson)
on Dec 21, 2001 at 22:10 UTC ( #133824=note: print w/ replies, xml ) Need Help??


in reply to How do you critique another person's code?

This sort of problem is quite common. Here's some code that appeared in comp.lang.perl.misc today:

if($match) { (($rank = @ranks[0]) && ($percent = "1%")) if $value == 1; (($rank = @ranks[1]) && ($percent = "2%")) if $value == 2; (($rank = @ranks[2]) && ($percent = "3%")) if $value == 3; (($rank = @ranks[3]) && ($percent = "4%")) if $value == 4; (($rank = @ranks[4]) && ($percent = "5%")) if $value == 5; (($rank = @ranks[5]) && ($percent = "6%")) if $value == 6; (($rank = @ranks[5]) && ($percent = "7%")) if $value == 7; (($rank = @ranks[6]) && ($percent = "8%")) if $value == 8; (($rank = @ranks[7]) && ($percent = "9%")) if $value == 9; (($rank = @ranks[8]) && ($percent = "10%")) if $value == 10; } $seniority = "$rank. ($percent)\n";
This always reminds me of the story of the Cobol programmer who was paid by the line.

The original article.

--
Mark Dominus
Perl Paraphernalia


Comment on Re: How do you critique another person's code?
Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://133824]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others about the Monastery: (7)
As of 2015-07-02 08:25 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (31 votes), past polls