Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"

Re: Re^4: Idiomatic optimizations

by demerphq (Chancellor)
on May 02, 2002 at 13:13 UTC ( #163529=note: print w/replies, xml ) Need Help??

in reply to Re^4: Idiomatic optimizations
in thread Idiomatic optimizations

Hmm I sort of agree with your point, but Im troubled by your fierce but syntactically incorrect example (ternary ops should always have the same number of '?' as ':' )
$a=1;$b=2;$c=3;$d=4;$f=5;$g=6;$h=7; $foo = $a? $b? $c : $d? $e : $f : $g : $h; print $foo; __END__ syntax error at C:\temp\ line 2, near "$g :" Execution of C:\temp\ aborted due to compilation errors.
I believe that you meant to say
$foo = $a ? $b ? $c : $d ? $e : $f : $g;
My personal rule of thumb is that ternary ops should not be nested but may be chained. Thus I would say that your example could be rewritten
$foo = !$a ? $g : $b ? $c : $d ? $e : $f;
And its a little less troublesome. Even then I personally would add some whitespace so it would look like
$foo = !$a ? $g : $b ? $c : $d ? $e : $f;
This and a bit of paretheses would also help your nested example
$foo = $a ? ($b ? $c : ($d ? $e : $f)) : $g;
I find that formatting ternaries like this makes them only marginally more difficult to read than if statements, but I still tend to avoid nested ternaries.

Yves / DeMerphq
Writing a good benchmark isnt as easy as it might look.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://163529]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others contemplating the Monastery: (5)
As of 2017-01-21 06:18 GMT
Find Nodes?
    Voting Booth?
    Do you watch meteor showers?

    Results (182 votes). Check out past polls.