Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"
 
PerlMonks  

•Re: Re: walking an array and unshifting

by merlyn (Sage)
on Jun 09, 2002 at 15:52 UTC ( [id://172918]=note: print w/replies, xml ) Need Help??


in reply to Re: walking an array and unshifting
in thread walking an array and unshifting

That's far too complicated a solution for me to leave standing after a code review if I was doing this formally.

If you merely want to avoid processing items based on their value, use a next in a foreach:

for $item (@list) { next if $item == 2 or $item == 4; ... rest of processing .. }
If you want a list that contains all but those items, then use a grep, as you said:
my @newlist = grep { $_ != 2 and $_ != 4 } @list;
But your for-loop monstrosity is ripe for off-by-one errors, and even if you got everything just right, your maintenance programmer would almost certainly break it.

Extra special hint: walking a list with for-style loops is almost always WRONG. Yes, there are counterexamples, but start with that.

-- Randal L. Schwartz, Perl hacker

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://172918]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others perusing the Monastery: (7)
As of 2024-03-28 11:24 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found