Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic

Re: Random Sampling

by Anonymous Monk
on Jun 25, 2002 at 20:22 UTC ( #177201=note: print w/replies, xml ) Need Help??

in reply to Random Sampling

Your selection_sample routine is not correctly coded. The idea is to randomly select a sample of n elements as you go, there should not be duplicates in the sample. Change your while loop to the following for a more faithful representation of Knuth's algorithm.
while ( @results < $num ) { if ( (@$array - $pos) * rand() < $num - @results ) { push @results, $array->[$pos]; } $pos++; }

Replies are listed 'Best First'.
Re: Re: Random Sampling
by demerphq (Chancellor) on Jun 26, 2002 at 17:02 UTC
    Hmm, while you are correct that my code was incorrect, I went with a different fix. My fix was simply to change the line
    push @results, $array->[$pos];
    push @results, $array->[$pos++];
    But thanks anyway. /me should have tested once or twice more. *sigh*

    Yves / DeMerphq
    Writing a good benchmark isnt as easy as it might look.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://177201]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (4)
As of 2018-01-18 20:12 GMT
Find Nodes?
    Voting Booth?
    How did you see in the new year?

    Results (214 votes). Check out past polls.