Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number

Re: moving files

by erikharrison (Deacon)
on Jun 29, 2002 at 16:42 UTC ( #178248=note: print w/ replies, xml ) Need Help??

in reply to moving files

Security! You don't check the value of $old for dangerous characters (shell metacharacters, etc) and you do no untainting, which tells me that you don't have untaint mode on. For your safety, I encourage you to enable taint mode and check your params for "safe" characters. I suggest the following regex to start, until you can accurately pin down the dangers.

$old =~ s/[^\w]//g; #or possibly throw a warning

As for the need to move files, File::Copy is probably your best bet. If you insist on not using modules (in this or other pursuits) the module is still the best place for and answer to the question "how do I do it". After all, it's just as valid as asking us for help, and the module is the most tested solution to the problem. Study prior art! :-)


Light a man a fire, he's warm for a day. Catch a man on fire, and he's warm for the rest of his life. - Terry Pratchet

Comment on Re: moving files
Download Code

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://178248]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others surveying the Monastery: (11)
As of 2015-10-08 17:26 GMT
Find Nodes?
    Voting Booth?

    Does Humor Belong in Programming?

    Results (222 votes), past polls