Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"
 
PerlMonks  

Re: Marge - the Interactive Marginalia Processor

by thraxil (Prior)
on Jul 08, 2002 at 21:33 UTC ( #180332=note: print w/replies, xml ) Need Help??


in reply to Marge - the Interactive Marginalia Processor

a few things:

  1. use CGI; this is of supreme importance.
  2. use strict; and -w
  3. taint checking. using -T would inform you that you are doing some very dangerous things using code like open(MARGE,">$pageroot.marge") where $pageroot just comes straight in from a parameter without any kind of scrubbing.
  4. the code would be much more readable if the HTML were seperated out via some kind of templating system like HTML::Template.
  5. code like if("$link" eq "some string") is bad. perl will treat $link as a string automatically; quoting it serves no purpose.

anders pearson

  • Comment on Re: Marge - the Interactive Marginalia Processor

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://180332]
help
Chatterbox?
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others browsing the Monastery: (9)
As of 2016-12-09 00:50 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    On a regular basis, I'm most likely to spy upon:













    Results (148 votes). Check out past polls.