Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris

Re: How to apply patches to PM code

by theorbtwo (Prior)
on Oct 02, 2002 at 19:22 UTC ( #202365=note: print w/replies, xml ) Need Help??

in reply to How to apply patches to PM code

One minor change: in step two, if you give up on the patch as being too poorly written or not useful enough to be worth the effort, please tell the author about it, either via the pmdev wiki or by /msging the author (depending on if you feel like public humilition of the author and getting more people potentialy working on changes).

I quite agree, BTW, about the problems of untestable code. The way I code requires lots of testing, both to verify exactly how things currently work, and to make sure the code I'm writing does what I think it does, so I end up trying to make very minimal changes to PM, or changes that are very localized. One thing that might be nice to get more pmdevils able to reasonably test is to set up a way to get the code of existing nodes en masse, or at least a little more easily -- AFAIK the best way to do it now is to view source and copy-and-paste out of the patching textbox. (I may hack up a little script to do this, or find a better way; I'm going to start on it now, and report back here when I'm done).

Warning: Unless otherwise stated, code is untested. Do not use without understanding. Code is posted in the hopes it is useful, but without warranty. All copyrights are relinquished into the public domain unless otherwise stated. I am not an angel. I am capable of error, and err on a fairly regular basis. If I made a mistake, please let me know (such as by replying to this node).

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://202365]
[Discipulus]: who make the invitation? the program?!?
[choroba]: it's historical
[erix]: pull requests
[choroba]: originally, you sent a pull request to someone by email, i.e. you asked them to pull from your repo
[Discipulus]: if is the author of a patch, is more like a 'request to push' into rather than a pull request..
[choroba]: as it's considered unpolite to push to someone else's repo
[choroba]: and in fact, you don't push into the target repo, you push into your branch of your fork
[choroba]: the maintainer of the upstream repo than "merges" the pull request, i.e. they pull from your fork into the upstream
[Discipulus]: ' i.e. you asked them to pull from your repo' =~ I (subj) want to push
[Discipulus]: chorobayour words are reasonable

How do I use this? | Other CB clients
Other Users?
Others browsing the Monastery: (6)
As of 2017-05-27 20:12 GMT
Find Nodes?
    Voting Booth?