Re^2: multiple method calls against the same object (f.ex GUI programming)

[Aristotle]

in reply to •Re: multiple method calls against the same object (f.ex GUI programming)
in thread multiple method calls against the same object (f.ex GUI programming)

I know about the first, but it wasn't possible here and also turns ugly when you have a multilevel call somewhere in that pile.

I was actually thinking the second is as good as I can do in this case. What I didn't like about topicalizing with a for in that case is that for one, I still have to mention the object for every method call, although at least it's only $_ now. And worse yet, I still need a temporary variable for every widget, even when it's a widget I don't care about having access to later (scrollbars often fall in this category f.ex).

By rearranging the program to use this snippet I managed to throw away about 4 out of 5 of my variables. That's more than a little win in clarity in my book.

But thanks for the suggestions. :-)

Makeshifts last the longest.

[merlyn]

And worse yet, I still need a temporary variable for every widget, even when it's a widget I don't care about having access to later (scrollbars often fall in this category f.ex).

In that case, it gets even easier:

for (Scrollbar->new) {
  $_->config1($param1);
  $_->config2($param2);
  $otherwidget->add($_);
}

Don't name anything you don't need to name!

-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.

[Aristotle]

Sorry, one steap ahead of you again. :-) That breaks down when you need to add a nameless widget to another also nameless widget:

for (HBox->new) {
  $_->config1($param1);
  $_->config2($param2);
  my $sb = Scrollbar->new;
  for ($sb) {
    $_->config1($param3);
    $_->config2($param4);
  }
  $_->add($sb);
  $window->add($_);
}

You need a temporary variable, although at least this one can be tightly scoped.

It also mingles method calls against several different widgets into a single block, which makes it harder to see what gets added where when. Your proposal is ok on a smaller scale, but scales badly - if you nest several unnamed widgets, it gets messy quick.

If you look at the tutorial at GtkPerl.org you'll see a really ugly style with lots of variable reuse and calls to different widgets interwoven in a single block. It made my head swim trying to read even the shorter example programs. configure_object was the result of several iterations of refactoring for readability.

It took enough effort and was beneficial enough that I felt I had to share this.

Update: Actually I suppose one can coerce the for approach into clean separation by adding some do to the mix:

$window->add(do {
  my $hbox = HBox->new;
  for ($hbox) {
    $_->config1($param1);
    $_->config2($param2);
    $_->add(do {
      my $sb = Scrollbar->new;
      for ($sb) {
        $_->config1($param3);
        $_->config2($param4);
      }
      $sb;
    });
  $hbox;
});

but that's quickly slipping into the realm of cumbersome. I really spent some serious time trying to get this whole deal to look reasonably readable, and no conventional tools would help, hence the snippet.

Makeshifts last the longest.