P is for Practical PerlMonks

Re: Zipcode Proximity script

by fizbin (Chaplain)
 on Apr 01, 2003 at 15:32 UTC ( #247259=note: print w/replies, xml ) Need Help??

in reply to Re: Re: Zipcode Proximity script

Whoops. This is what I get for coding after my brain has already shut down for nightly maintenance.

Those quick_accept and quick_reject routines will give false rejections with longitudes near the 180 degree longitude. (not an issue with US locations, I know, but...) Also, there's a stupid bit of time-wasting going on near the top there.

Let's see if I can get it right this time:

```sub make_quick_reject {
my(\$lat,\$long,\$dist) = @_;
if (abs(\$lat) + \$maxlatdiff > PI/2) {
# special case - near poles
return sub { abs(\$lat - \$_[0]) > \$maxlatdiff; };
}
my(\$longmult);
\$longmult = 1 / cos(abs(\$lat) + \$maxlatdiff);
my(\$maxlongdiff) = \$maxlatdiff * \$longmult;
return sub { abs(\$lat - \$_[0]) > \$maxlatdiff or
( abs(\$long - \$_[1]) > \$maxlongdiff and
abs(\$long - \$_[1]) < 2*PI - \$maxlongdiff ); };
}

sub make_quick_accept {
my(\$lat,\$long,\$dist) = @_;
\$maxlatdiff /= sqrt(2);
my(\$longmult);
if (abs(\$lat) < \$maxlatdiff ) {
# special case - near equator
\$longmult = 1;
} else {
\$longmult = 1 / cos(abs(\$lat) - \$maxlatdiff);
}
my(\$maxlongdiff) = \$maxlatdiff * \$longmult;
return sub { abs(\$lat - \$_[0]) < \$maxlatdiff and
( abs(\$long - \$_[1]) < \$maxlongdiff or
abs(\$long - \$_[1]) > 2*PI - \$maxlongdiff ); };
}

And just again as a reminder, the sub's produced by these two routines accept longitudes and latitudes in RADIANS, not degrees. (Though reworking them to use degrees instead of radians should not be difficult at all)

And if anyone uses this code without understanding how it works, they deserve what they get. No warranty of anything useful implied at all; the code may not even pass perl -c.

Create A New User
Node Status?
node history
Node Type: note [id://247259]
help
Chatterbox?
 [Discipulus]: good morning marto

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (5)
As of 2018-02-20 10:14 GMT
Sections?
Information?
Find Nodes?
Leftovers?
Voting Booth?
When it is dark outside I am happiest to see ...

Results (268 votes). Check out past polls.

Notices?