Re: IYHO, what do you consider good code?

[one4k4]

in reply to IYHO, what do you consider good code?

Turn off debug statements. I don't know how many times I've had to read through apache error_log files and determine what/where/why/when some piece of code written by somebody here is writing to stderr..

I find it useful to do things like warn $sth when developing, but forgetting to remove those bits leads to production log file messes.

:) Just my $0.02

One4k4 - [e-mail] (www.poorheart.com)

[Anonymous Monk]

Usually when writing debug code, I will use this type of statement (for just the reason above)...

use constant DEBUG => 1;
...
...
warn "Foo" if DEBUG;

or

use constant DEBUG => 1;
...
...
my $debugsub = DEBUG ? { warn @_ } : {}; #need to fix stack trace...
...
...
&$debugsub(foobar);

Allows turning it off in one location. Just my $0.02.

[chromatic]

Make it an environment variable and it's even easier:

BEGIN
{
   $ENV{DEBUG} = $ENV{DEBUG} ? 0 : 1;
}
use constant DEBUG => $ENV{DEBUG};

Update: Good points both responses, though I'm slightly happier with the BEGIN block from a maintenance standpoint.

[diotalevi]

Make it a more specific environment variable and you're golden. Alzabo respects the ALZABO_DEBUG environment variable, your modules could do something similar.

[Juerd]

BEGIN { $ENV{DEBUG} = $ENV{DEBUG} ? 0 : 1; } use constant DEBUG => $ENV{DEBUG};

Why the BEGIN block?

use constant DEBUG => !!$ENV{DEBUG};

Juerd # { site => 'juerd.nl', plp_site => 'plp.juerd.nl', do_not_use => 'spamtrap' }