Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling

Re: Re: First Time Untainting Data

by svsingh (Priest)
on Oct 10, 2003 at 17:05 UTC ( #298322=note: print w/replies, xml ) Need Help??

in reply to Re: First Time Untainting Data
in thread First Time Untainting Data

Thanks for the tip. I rewrote the untaint subroutine as follows (borrowing from perlsec):
sub untaint { my $s = $_[0]; if ($s =~ /^([\w \-\@\(\)\,\.\/]+)$/) { $s = $1; # $data now untainted } else { die "Bad data in $s"; # log this somewhere } return $s; }

When I get home, I'll look into writing a separate untaint subroutine for each field, but is this more correct than the original?

Thanks again.

Replies are listed 'Best First'.
Re: First Time Untainting Data
by Abigail-II (Bishop) on Oct 10, 2003 at 17:10 UTC
    This is at least a syntactical valid way of untainting the data, but I do not know whether it's semantically correct. That depends on how the data is used. And do yourself (and all readers of your code), don't backwack everything. Only use a backslash when it's really needed. Like this:
    if ($s =~ m{^([-\w \@(),./]+)$}) {


Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://298322]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (7)
As of 2017-05-26 13:22 GMT
Find Nodes?
    Voting Booth?